pre-commit: autoupdate hook versions

[github-actions]

Base PullRequest

default branch (https://github.com/pydata/xarray/tree/main)

Command results

Details:

add path

/home/runner/work/_actions/technote-space/create-pr-action/837dbe469b39f08d416889369a52e2a993625c84/node_modules/npm-check-updates/bin

python -m pre_commit autoupdate

Updating https://github.com/pre-commit/pre-commit-hooks ... [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
already up to date.
Updating https://github.com/PyCQA/isort ... [INFO] Initializing environment for https://github.com/PyCQA/isort.
updating 5.9.3 -> 5.10.0.
Updating https://github.com/psf/black ... [INFO] Initializing environment for https://github.com/psf/black.
updating 21.9b0 -> 21.10b0.
Updating https://github.com/keewis/blackdoc ... [INFO] Initializing environment for https://github.com/keewis/blackdoc.
already up to date.
Updating https://gitlab.com/pycqa/flake8 ... [INFO] Initializing environment for https://gitlab.com/pycqa/flake8.
already up to date.
Updating https://github.com/pre-commit/mirrors-mypy ... [INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy.
already up to date.

python -m pre_commit run --all-files

[INFO] Initializing environment for https://github.com/psf/black:.[jupyter].
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy:numpy,types-PyYAML,types-pkg_resources,types-python-dateutil,types-pytz,typing-extensions==3.10.0.0.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/PyCQA/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/psf/black.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/psf/black.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/keewis/blackdoc.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://gitlab.com/pycqa/flake8.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check Yaml...............................................................Passed
isort....................................................................Failed
- hook id: isort
- files were modified by this hook

Fixing /home/runner/work/xarray/xarray/xarray/tests/test_distributed.py

black....................................................................Failed
- hook id: black
- files were modified by this hook

reformatted xarray/tests/test_distributed.py
All done! ✨ 🍰 ✨
1 file reformatted, 164 files left unchanged.

black-jupyter............................................................Passed
blackdoc.................................................................Passed
flake8...................................................................Passed
mypy.....................................................................Passed

Changed files

Changed 2 files:

• .pre-commit-config.yaml
• xarray/tests/test_distributed.py

---

Repo | 📝 Issues | 🏬 Marketplace

[max-sixty]

I would have thought that the isort: skip would be necessary, and this would cause the tests to fail... And unsure why it's not skipped with this upgrade!

[Illviljan]

@max-sixty It didn't run the tests for some reason. But now those tests are indeed crashing.

[github-actions]

Unit Test Results

         6 files  ±0           6 suites  ±0   55m 38s ⏱️ +24s
16 290 tests ±0  14 551 ✔️  - 1  1 739 💤 +1  0 ❌ ±0 
90 936 runs  ±0  82 738 ✔️  - 1  8 198 💤 +1  0 ❌ ±0 

Results for commit f206ee2. ± Comparison against base commit 402a9b3.

[keewis]

It didn't run the tests for some reason

github workflows can't trigger other workflow runs with the default token (secrets.GITHUB_TOKEN). I didn't know that manually reopening would make it run, though.

[max-sixty]

IIUC, #5955 is a better version of this GHA, and runs tests because it's a PR rather than a workflow. Is that right? I can remove this GHA if so...

[keewis]

I can remove this GHA if so...

yes, please. If we agree that pre-commit.ci is the way forward we can definitely remove the old update CI (see also #5940 (comment))