Skip to content

Only run asv benchmark when labeled #5893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2021
Merged

Only run asv benchmark when labeled #5893

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fbf8f71
Only run benchmark when labeled
Illviljan Oct 24, 2021
68a2663
Update benchmarks.yml
Illviljan Oct 24, 2021
3273149
Update benchmarks.yml
Illviljan Oct 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,7 @@ on:

jobs:
benchmark:
if: |
${{ contains( github.event.pull_request.labels.*.name, 'run-benchmark')
&& github.event_name == 'pull_request'
|| github.event_name == 'workflow_dispatch' }}
if: ${{ contains( github.event.pull_request.labels.*.name, 'run-benchmark') && github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to alternatively allow setting a tag in the commit message? I think it's more likely someone will need to test the performance of specific commits rather than the whole PR. We could even extend ci-trigger to optionally detect labels on PRs...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I think adding or removing a label is much easier than to remember to add a tag in the commit message. I rarely get it right the first (or second) commit anyway so remembering to add it in several messages is a tough task. The benchmark takes about the same time as the other tests now so I don't think it won't be that much of a bottleneck if it runs a few more times than necessary.

Adding labels is however an admin-only thing so if other contributors want's to run it without asking the maintainers a tag in the commit is good a option.

name: Linux
runs-on: ubuntu-20.04
env:
Expand Down