Skip to content

Clarify drop_vars return value. #4244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 14, 2020
Merged

Clarify drop_vars return value. #4244

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee6e93b
Clarify drop_vars return value.
rpgoldman Jul 21, 2020
7a5168d
Update xarray/core/dataarray.py
rpgoldman Jul 26, 2020
5641c35
Update xarray/core/dataarray.py
dcherian Aug 14, 2020
f648f41
Merge branch 'master' of github.com:pydata/xarray into drop-vars-doc
dcherian Aug 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xarray/core/dataarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1928,7 +1928,7 @@ def T(self) -> "DataArray":
def drop_vars(
self, names: Union[Hashable, Iterable[Hashable]], *, errors: str = "raise"
) -> "DataArray":
"""Drop variables from this DataArray.
"""Drop variables from this DataArray. *Not* done inplace.

Parameters
----------
Expand All @@ -1942,7 +1942,7 @@ def drop_vars(
Returns
-------
dropped : Dataset

New Dataset copied from ``self`` with variables removed.
"""
ds = self._to_temp_dataset().drop_vars(names, errors=errors)
return self._from_temp_dataset(ds)
Expand Down