Combining attrs of member DataArrays of Datasets #4017
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at #4009, I noticed that the
combine_attrskwarg toconcatormergeonly affects the global attrs of theDataset, not the attrs ofDataArrayorVariablemembers of theDatasets being combined. I think this is a bug.So far this PR adds tests that reproduce the issue in #4009, and the issue described above. Fixing should be fairly simple: for #4009 pass
combine_attrs="drop"tocombine_by_coordsandcombine_nestedinopen_mfdataset; for this issue insert thecombine_attrshandling in an appropriate place - possibly inmerge.unique_variable. I'll update with fixes when I get a chance.isort -rc . && black . && mypy . && flake8whats-new.rstfor all changes andapi.rstfor new API