Restrict pytest to 'unit' tests (i.e. not hypothesis) #3471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
That was a conscious decision based on the observation that the whole lot of the hypothesis tests was taking something like 3 seconds. Has this changed now? |
Collaborator
Author
|
Ah. Am I thinking there's a separate hypothesis job when actually there isn't? |
Contributor
|
@max-sixty there used to. I took it away. |
Contributor
|
End-to-end runtime for properties, as of the git tip, is 1.65 seconds |
Collaborator
Author
|
Great. Thanks for being ahead of me on some of these recent issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Azure is running hypothesis tests in any test job that has hypothesis installed (found in #3285). This isn't required, since we have a separate job for hypothesis, and slows down the normal tests.
We can either exclude it in the test job or in the tests that pytest runs as specified in
setup.cfgI think adjusting pytest's test paths in
setup.cfgis a more logical place: pytest is responsible for running normal / unit tests inxarray/tests, and hypothesis can run the tests inproperties