Skip to content

Error in leap year? #3464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcherian merged 6 commits into from
Oct 30, 2019
Merged

Error in leap year? #3464

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e183c7a
Typo correction in docs (#3387)
christophcc Oct 9, 2019
d197c81
Update terminology.rst (#3455)
amcnicho Oct 29, 2019
8d50626
Error in leap year?
mickaellalande Oct 30, 2019
89caa3e
Merge branch 'master' into pr/mickaellalande/3464
max-sixty Oct 30, 2019
fea8f61
Fix leap year (pydata#3464)
mickaellalande Oct 30, 2019
563f966
Update doc/whats-new.rst
mickaellalande Oct 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/examples/monthly-means.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ the ``calendar.month_range`` function.

for i, (month, year) in enumerate(zip(time.month, time.year)):
month_length[i] = cal_days[month]
if leap_year(year, calendar=calendar):
if leap_year(year, calendar=calendar) and month == 2:
month_length[i] += 1
return month_length

Expand Down
2 changes: 1 addition & 1 deletion doc/whats-new.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ Bug fixes

Documentation
~~~~~~~~~~~~~

- Fix leap year (http://xarray.pydata.org/en/stable/examples/monthly-means.html) by `Mickaël Lalande <https://github.com/mickaellalande>`_.
- Fix the documentation of :py:meth:`DataArray.resample` and
:py:meth:`Dataset.resample` and explicitly state that a
datetime-like dimension is required. (:pull:`3400`)
Expand Down