Drop keyword support: small fixes #3233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g DataArrayCoordinates (pydata#2910).
Contributor
Author
|
Strange. This passes all my tests locally. |
max-sixty
reviewed
Aug 20, 2019
Collaborator
|
The failure is b/c of an upstream package; we can ignore |
max-sixty
approved these changes
Aug 20, 2019
Collaborator
max-sixty
left a comment
max-sixty
left a comment
There was a problem hiding this comment.
Great, thanks for adding those two changes
I'll merge tomorrow unless any other changes
shoyer
reviewed
Aug 20, 2019
Contributor
Author
|
@shoyer, I've addressed your comments by adding more helpful warnings and testing that said warnings are raised properly. I've also moved both warnings to the top of the function as I think it's a bit easier to reason about the code branches this way. |
|
Hello @gwgundersen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-08-23 20:57:22 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dataset.drop#3128.black .andflake8.whats-new.rstandindexing.rst.