Bugfix/reduce no axis #2769
Merged
Bugfix/reduce no axis #2769
+28
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-sixty
reviewed
Feb 13, 2019
xarray/core/variable.py
Outdated
| data = func(self.data if allow_lazy else self.values, | ||
| axis=axis, **kwargs) | ||
| else: | ||
| data = func(self.data if allow_lazy else self.values, **kwargs) |
Collaborator
There was a problem hiding this comment.
This no longer passes axis=None into func, which I think is reasonable - it's generally the default. (but someone should confirm my thinking)
Member
There was a problem hiding this comment.
This looks good to me, though I would rewrite this to an intermediate variable for self.data if allow_lazy else self.values rather than writing it out twice
Member
Author
There was a problem hiding this comment.
Done, should be ready for merging now.
Closed
Member
|
Thanks! |
dcherian
added a commit
to yohai/xarray
that referenced
this pull request
Mar 18, 2019
* upstream/master: Rework whats-new for 0.12 Add whats-new for 0.12.1 Release 0.12.0 enable loading remote hdf5 files (pydata#2782) Push back finalizing deprecations for 0.12 (pydata#2809) Drop failing tests writing multi-dimensional arrays as attributes (pydata#2810) some docs updates (pydata#2746) Add support for cftime.datetime coordinates with coarsen (pydata#2778) Don't use deprecated np.asscalar() (pydata#2800) Improve name concat (pydata#2792) Add `Dataset.drop_dims` (pydata#2767) Quarter offset implemented (base is now latest pydata-master). (pydata#2721) Add use_cftime option to open_dataset (pydata#2759) Bugfix/reduce no axis (pydata#2769) 'standard' now refers to 'gregorian' in cftime_range (pydata#2771)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstfor all changes andapi.rstfor new API