Fix test_88_character_filename_segmentation_fault #2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test turning all warnings into errors. Now it's more robust, and only converts the appropriate warning into an error. Fixes GH2025
stickler-ci
reviewed
Mar 29, 2018
xarray/backends/netCDF4_.py
Outdated
| if (len(filename) == 88 and | ||
| LooseVersion(nc4.__version__) < "1.3.1"): | ||
| warnings.warn( | ||
| <<<<<<< Updated upstream |
Contributor
There was a problem hiding this comment.
E122 continuation line missing indentation or outdented
E999 SyntaxError: invalid syntax
E225 missing whitespace around operator
E227 missing whitespace around bitwise or shift operator
xarray/backends/netCDF4_.py
Outdated
| 'upgrading netCDF4 to at least version 1.3.1.\n' | ||
| 'More details can be found here:\n' | ||
| 'https://github.com/pydata/xarray/issues/1745 \n') | ||
| ======= |
Contributor
There was a problem hiding this comment.
E305 expected 2 blank lines after class or function definition, found 0
E225 missing whitespace around operator
| 'More details can be found here:\n' | ||
| 'https://github.com/pydata/xarray/issues/1745 \n') | ||
| ======= | ||
| 'A segmentation fault may occur when the ' |
Contributor
There was a problem hiding this comment.
E113 unexpected indentation
xarray/backends/netCDF4_.py
Outdated
| 'upgrading netCDF4 to at least version 1.3.1. ' | ||
| 'More details can be found here: ' | ||
| 'https://github.com/pydata/xarray/issues/1745') | ||
| >>>>>>> Stashed changes |
Contributor
There was a problem hiding this comment.
E128 continuation line under-indented for visual indent
W503 line break before binary operator
E225 missing whitespace around operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was turning all warnings into errors. Now it's more robust, and only
converts the appropriate warning into an error.