Skip to content

Add names for test failures #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maaleske wants to merge 10 commits into from
Closed

Add names for test failures #1690

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8ff4e3c
Add coordinate name to test failure output
maaleske Nov 3, 2017
b3e4cdd
Add change to whats-new.rst
maaleske Nov 3, 2017
65cffc4
Fix whitespace
maaleske Nov 3, 2017
d156cb9
Better reference
maaleske Nov 3, 2017
502e24b
Add optional name parameter for test failure identification
maaleske Nov 6, 2017
17a2491
Add name passthrough to recursive call
maaleske Nov 6, 2017
c101890
Fix indentation
maaleske Nov 6, 2017
821ac69
Update whats-new.rst
maaleske Nov 6, 2017
08293c7
Merge branch 'master' into coord-names-to-tests
shoyer Nov 7, 2017
b3e2b6d
Switch default value of name to None
maaleske Nov 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions doc/whats-new.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ Bug fixes
of ``.T`` attributes. (:issue:`1675`).
By `Keisuke Fujii <https://github.com/fujiisoup>`_

Testing
~~~~~~~

- Add coordinate names to failure printout for
:py:func:`xarray.testing.assert_allclose`.
By `Matti Eskelinen <https://github.com/maaleske>`_

v0.10.0 rc1 (30 October 2017)
-----------------------------
Expand Down
5 changes: 3 additions & 2 deletions xarray/testing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,9 @@ def assert_allclose(a, b, rtol=1e-05, atol=1e-08, decode_bytes=True):
# DataArray, so call into _data_allclose_or_equiv directly
allclose = _data_allclose_or_equiv(a.coords[v].values,
b.coords[v].values, **kwargs)
assert allclose, '{}\n{}'.format(a.coords[v].values,
b.coords[v].values)
assert allclose, 'coord {}:{}\n{}'.format(a.coords[v].name,
a.coords[v].values,
b.coords[v].values)
Copy link
Member

@shoyer shoyer Nov 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding name to the error message for non-coordinates, too? We could do this by adding an optional name argument to this function. (It would also be useful for assert_equal and assert_identical.)

elif isinstance(a, xr.Dataset):
assert set(a.data_vars) == set(b.data_vars)
assert set(a.coords) == set(b.coords)
Expand Down