Skip to content

Fix errors with isnull() that appear with pandas 0.21#1549

Merged
shoyer merged 1 commit intopydata:masterfrom
shoyer:isnull-isna-patch
Sep 5, 2017
Merged

Fix errors with isnull() that appear with pandas 0.21#1549
shoyer merged 1 commit intopydata:masterfrom
shoyer:isnull-isna-patch

Conversation

@shoyer
Copy link
Member

@shoyer shoyer commented Sep 2, 2017

xref #1542

  • Tests added / passed
  • Passes git diff upstream/master | flake8 --diff
  • Fully documented, including whats-new.rst for all changes and api.rst for new API

@shoyer
Copy link
Member Author

shoyer commented Sep 2, 2017

The culprit is the truly monstrous _func_slash_method_wrapper function where we read names from methods if need be:
https://github.com/pydata/xarray/blob/master/xarray/core/ops.py#L211-L216

We should have a more sane way to add methods on xarray objects, but this fix will have to do for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants