Fix to_netcdf(compute=False) with Dask distributed #10730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
approved these changes
Sep 10, 2025
|
Looks like there's a typing error preventing this from getting merged. |
Do you understand what's going on? The errors I see all look something like I'm not even entirely sure how to run those tests, but I definitely didn't touch anything related to |
|
ugh usually the other mypy CI also fails and is more readable :/ I do see
but why hasn't the other one failed? Presumably a version difference? |
|
I figured out how to silence it for now. |
shoyer
added a commit
to shoyer/xarray
that referenced
this pull request
Sep 16, 2025
* Fix to_netcdf(compute=False) with Dask distributed Fixes pydata#10725 * Silence incorrect mypy error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rst