propagate attrs on coords in Dataset.map
#10602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is a good improvement for |
|
agree! can we merge and then I'll merge into #10726 |
|
If I can count your comments as two approvals, then that should be enough to merge once CI passes |
shoyer
pushed a commit
to shoyer/xarray
that referenced
this pull request
Sep 16, 2025
* check that weighted ops propagate attrs on coords * propagate attrs on coords in `map` if keep_attrs * directly check that `map` propagates attrs on coords * whats-new
5 tasks
max-sixty
added a commit
to max-sixty/xarray
that referenced
this pull request
Oct 9, 2025
After PR pydata#10602, Dataset.map started failing when functions returned non-DataArray values (e.g., scalars), raising AttributeError when trying to access .coords on the returned values. This restores backward compatibility by converting non-DataArray outputs to DataArrays, which was the behavior before the regression. Fixes pydata#10835 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
4 tasks
max-sixty
added a commit
that referenced
this pull request
Oct 10, 2025
After PR #10602, Dataset.map started failing when functions returned non-DataArray values (e.g., scalars), raising AttributeError when trying to access .coords on the returned values. This restores backward compatibility by converting non-DataArray outputs to DataArrays, which was the behavior before the regression. Fixes #10835 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstThis makes sure we propagate attrs in coords in
Dataset.mapifkeep_attrs == True. It uses the same semantics as for the data variables, which means thatkeep_attrs=Truewill overwrite any changes to the attrs by the mapped function.This hides the use of the division operator in some of the weighted operations, which are solely affected by the global
keep_attrsproperty.Alternative implementation options:
DataArray._copy_attrs_fromiterate over the coordinates.Dataset.map, we could also make all weighted ops receive akeep_attrsparameter