Skip to content

Fix doctests by ignoring warning from netcdf #10599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2025
Merged

Fix doctests by ignoring warning from netcdf #10599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8589b6
Fix doctests by ignoring warning from netcdf
jsignell Aug 1, 2025
d4805c5
Fix mypy issues in tests
jsignell Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions xarray/tests/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
warnings.filterwarnings("ignore", "'urllib3.contrib.pyopenssl' module is deprecated")
warnings.filterwarnings("ignore", "Deprecated call to `pkg_resources.declare_namespace")
warnings.filterwarnings("ignore", "pkg_resources is deprecated as an API")
warnings.filterwarnings("ignore", message="numpy.ndarray size changed")

arm_xfail = pytest.mark.xfail(
platform.machine() == "aarch64" or "arm" in platform.machine(),
Expand Down
17 changes: 12 additions & 5 deletions xarray/tests/test_plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,9 +331,10 @@ def test_2d_line_accepts_legend_kw(self) -> None:
assert not plt.gca().get_legend()
plt.cla()
self.darray[:, :, 0].plot.line(x="dim_0", add_legend=True)
assert plt.gca().get_legend()
legend = plt.gca().get_legend()
assert legend is not None
# check whether legend title is set
assert plt.gca().get_legend().get_title().get_text() == "dim_1"
assert legend.get_title().get_text() == "dim_1"

def test_2d_line_accepts_x_kw(self) -> None:
self.darray[:, :, 0].plot.line(x="dim_0")
Expand All @@ -344,10 +345,14 @@ def test_2d_line_accepts_x_kw(self) -> None:

def test_2d_line_accepts_hue_kw(self) -> None:
self.darray[:, :, 0].plot.line(hue="dim_0")
assert plt.gca().get_legend().get_title().get_text() == "dim_0"
legend = plt.gca().get_legend()
assert legend is not None
assert legend.get_title().get_text() == "dim_0"
plt.cla()
self.darray[:, :, 0].plot.line(hue="dim_1")
assert plt.gca().get_legend().get_title().get_text() == "dim_1"
legend = plt.gca().get_legend()
assert legend is not None
assert legend.get_title().get_text() == "dim_1"

def test_2d_coords_line_plot(self) -> None:
lon, lat = np.meshgrid(np.linspace(-20, 20, 5), np.linspace(0, 30, 4))
Expand Down Expand Up @@ -2917,7 +2922,9 @@ def test_legend_labels(self) -> None:
pc = ds2.plot.scatter(x="A", y="B", markersize="hue")
axes = pc.axes
assert axes is not None
actual = [t.get_text() for t in axes.get_legend().texts]
legend = axes.get_legend()
assert legend is not None
actual = [t.get_text() for t in legend.texts]
expected = ["hue", "a", "b"]
assert actual == expected

Expand Down
Loading