Skip to content

Add NBSphinx support for dark theme#741

Merged
choldgraf merged 17 commits intomainfrom
fix-nbsphinx-dark
Jun 27, 2022
Merged

Add NBSphinx support for dark theme#741
choldgraf merged 17 commits intomainfrom
fix-nbsphinx-dark

Conversation

@choldgraf
Copy link
Copy Markdown
Collaborator

@choldgraf choldgraf commented Jun 18, 2022

This PR does a few cleanups and improvements:

I don't believe that we can demo both nbsphinx and myst-nb in the same docs (they both grab the ipynb extension so can only use one). But I believe this does it and we'll need to rely on community reports if functionality breaks.

@blaylockbk want to test that this works OK for your use-case?

closes #739

@choldgraf
Copy link
Copy Markdown
Collaborator Author

Note that the broken link test is now fixed on main

@choldgraf
Copy link
Copy Markdown
Collaborator Author

I double-checked this locally and it seems to work well w/ nbsphinx:

chrome_DWJYg869mu

I also added some instructions for how others could test nbsphinx locally.

I think we are good to merge this unless anybody objects!

@choldgraf
Copy link
Copy Markdown
Collaborator Author

OK I'm gonna merge this one in because it's fixing a display bug, and (at least locally) I think I've fixed it!

@choldgraf choldgraf merged commit 75380a7 into main Jun 27, 2022
@choldgraf choldgraf deleted the fix-nbsphinx-dark branch June 27, 2022 14:17
@jarrodmillman jarrodmillman added this to the 0.10 milestone Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pandas/xarray HTML representation in dark theme

2 participants