-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Ignore black format changes #713
Conversation
Can you please provide a little bit more context of the "what and the why"? I don't understand what this diff means, or why it is important to "ignore black format changes". It seems reasonable to me but I don't really know why I think that haha, I think it'd be helpful for others to understand and learn if we had a bit more info. Is the goal here to prevent github from having noise about changes that were related to a bot? Is there some way we can automate this process? Or do we have to manually update it each time? |
To see how this works, consider this commit That commit touched several files, but mostly applied autoformatting changes. When you use See After merging this PR you would get In particular, you can see the difference by comparing lines 7--9. I am not aware of any automated tool to do this, but it isn't a problem and the commits can be added to the file at any time. I don't think this is super important. Personally, I don't have any trouble ignoring the handful of formatting commits when using I would be happy if this was merged, but would also be happy if it wasn't. |
I'm +1 on merging this, as long as we either:
I just don't want to add a dangling file that many people might not be familiar with without also adding a little bit of documentation :-) |
17d6805
to
a07ad87
Compare
a07ad87
to
119a72b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for adding these extra explanations and links :-)
See the comment below for an explanation of this: #713 (comment)