Version switcher provides explicit URLs#604
Conversation
damianavila
left a comment
There was a problem hiding this comment.
LGTM, I like the explicitness of the approach.
|
@choldgraf, pushed a new commit after fixing the merge conflicts, feel free to re-review and merge this one. |
|
Thanks @damianavila ! Just to confirm, I believe that @tupui was 👍 on this change - if anybody else objects please weigh in. Otherwise I'll merge this in a day or two. |
|
Yes I am 👍 Thanks for doing this! Can't wait to use it. |
|
In the future when options are removed, it might be worth emitting a warning in the sphinx build. If I had seen a message like: it would have saved me a bit of pain. Also the failures are silent currently as our links are now to |
|
oops - sorry that this created some pain for you. Maybe I was mistaken but I thought we had not yet released this feature which is why I didn't think to deprecate it...I might have missed a release though :-/ |
|
It looks like pandas hit it and their workaround was to pin to 8.0.0, so it was probably in there? Not sure though... |
|
yep you are correct, my bad :-( https://github.com/pydata/pydata-sphinx-theme/releases/tag/v0.8.0 |
This removes the
url_templateparameter of our version switcher, and instead has users explicitly give a URL for each of the versions specified in their version switcher JSON.closes #600