STYLE: Update default anchor link#593
Merged
choldgraf merged 1 commit intopydata:masterfrom Feb 23, 2022
Merged
Conversation
choldgraf
force-pushed
the
style-anchor-link
branch
from
be05043 to
2f84e0c
Compare
choldgraf
force-pushed
the
style-anchor-link
branch
from
2f84e0c to
22d9f06
Compare
damianavila
approved these changes
Feb 22, 2022
Collaborator
damianavila
left a comment
damianavila
left a comment
There was a problem hiding this comment.
LGTM, I like the # version of the link!
Collaborator
Author
|
Will hold off for 24hrs or so to merge in case others have thoughts! |
Member
|
Nice improvement! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This demonstrates what our docs would look like with a
#as the default anchor link, rather than the paragraph icon. I also updated some of the CSS for the anchors itself, to be a little bit more visually pleasing, and following the Bootstrap docs style/behaviorOLD:
NEW:
closes #592