ENH: add optional per version url in version-switcher #575
Conversation
tupui
force-pushed
the
version_switcher_url
branch
from
a58caff to
cdb4295
Compare
drammock
left a comment
drammock
left a comment
There was a problem hiding this comment.
I didn't test (no computer access, only phone) but the code changes look correct to me
| switcher. | ||
| - ``name``: an optional name to display in the switcher dropdown instead of the | ||
| version string (e.g., "latest", "stable", "dev", etc). | ||
| - ``url``: an optional URL. If provided, it links the version to ``url`` |
There was a problem hiding this comment.
Could you add an example of this usage in one of the entries in the example below, with a comment like "Note that because url is specified for entry XXX, this URL will be used instead of the automatically-generated one."
There was a problem hiding this comment.
I've added it in an example. But since it's a JSON file I cannot really add a comment no??
damianavila
left a comment
damianavila
left a comment
There was a problem hiding this comment.
LGTM (modulo @choldgraf is OK with the added example on his comment).
|
@choldgraf can you please take another look? 😃 |
choldgraf
left a comment
choldgraf
left a comment
There was a problem hiding this comment.
Just a quick comment about wording but this looks good to me as well!
Co-authored-by: Chris Holdgraf <[email protected]>
|
Thanks! 🎉 |
4 participants
Closes #573
Allow to specify
urlinswitcher.json. It would directly link a given version to the specified url and not useurl_template.