Skip to content

Commit

Permalink
MNT: Deprecate python 3.7 and 3.8
Browse files Browse the repository at this point in the history
`setuptools` has removed some stuff needed to build numpy on old
platforms: numpy/numpy#27405

So the musllinux distributions on 3.8 don't build anymore. I tried
to enforce setuptools<74 for python < 3.9, but it seems pip doesn't
guarantee the order of the dependencies, so `oldest-supported-numpy`
gets installed before setuptools is, failing...

For simplicity I'm removing support for these versions
  • Loading branch information
rdbisme committed Oct 13, 2024
1 parent d3cfda8 commit c1f9529
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
architecture: [x86, x64]
os:
[
Expand Down Expand Up @@ -68,7 +68,7 @@ jobs:
- name: Build wheels
uses: pypa/[email protected]
env:
CIBW_SKIP: pp* cp36-*
CIBW_SKIP: pp* cp36-* cp37-* cp38-*

- name: Store wheel artifacts
uses: actions/upload-artifact@v4
Expand Down
1 change: 1 addition & 0 deletions RELEASE.rst
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Bottleneck 1.4.1
Enhancements
~~~~~~~~~~~~
- Deprecate Python 3.7 and 3.8
- Add python 3.13 build

Bottleneck 1.4.0
Expand Down
8 changes: 3 additions & 5 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
[build-system]
requires = [
# Setuptools has removed support for msvccompiler
# this is needed to build old versions of bottleneck
"setuptools",
"versioneer",
"wheel",
"oldest-supported-numpy ; python_version < '3.9'",
# Setuptools has removed support for msvccompiler
# this is needed to build old versions of bottleneck
"setuptools<74 ; python_version < '3.9'",
# Comments on numpy build requirement range:
#
# 1. >=2.0.x is the numpy requirement for wheel builds for distribution
Expand All @@ -17,5 +15,5 @@ requires = [
# and disabling build isolation.
# 3. The <2.3 upper bound is for matching the numpy deprecation policy,
# it should not be loosened
"numpy>=2.0.0rc1,<2.3 ; python_version >= '3.9'",
"numpy>=2,<2.3"
]

0 comments on commit c1f9529

Please sign in to comment.