New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cli_exit_on_error config option #340

Merged

hramezani merged 10 commits into pydantic:main from kschwab:remove_cli_system_exit

Jul 19, 2024

Contributor

kschwab commented Jul 10, 2024

Fixes #336

kschwab added 4 commits

July 10, 2024 08:04


          Remove CLI exit on error and raise SettingsError instead.

01c19cf


          Lint.

678a8d6


          Lint.

42b1742


          Add match.

4849f11

kschwab marked this pull request as draft

July 10, 2024 15:01

kschwab added 4 commits

July 10, 2024 09:38


          Add cli_exit_on_error config.

259f67b


          Lint.

42e4c16


          Lint.

fbdce00


          More lint.

57e416c

kschwab changed the title ~~Remove CLI exit on error and raise SettingsError instead.~~ Add cli_exit_on_error config option

kschwab marked this pull request as ready for review

July 10, 2024 15:47


          Merge branch 'main' into remove_cli_system_exit

bc4737d

Member

hramezani commented Jul 18, 2024

@kschwab are you done?
@mpkocher do you want to take a look at this PR?

Contributor Author

kschwab commented Jul 19, 2024

@hramezani yes, no more changes for this PR. It's ready to go.

hramezani approved these changes

View reviewed changes


          Merge branch 'main' into remove_cli_system_exit

b6e1721

hramezani merged commit 4840d69 into pydantic:main

18 checks passed

Member

hramezani commented Jul 19, 2024

Thanks @kschwab

mr-kamran-ali referenced this pull request in robert-koch-institut/mex-common


          Update dependency pydantic-settings to v2.4.0 (#254)

df711d6

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [pydantic-settings](https://github.com/pydantic/pydantic-settings)
([changelog](https://github.com/pydantic/pydantic-settings/releases))
| project.dependencies | minor | `==2.3.4` -> `==2.4.0` |

---

### Release Notes

<details>
<summary>pydantic/pydantic-settings (pydantic-settings)</summary>

###
[`v2.4.0`](https://github.com/pydantic/pydantic-settings/releases/tag/v2.4.0)

[Compare
Source](https://github.com/pydantic/pydantic-settings/compare/v2.3.4...v2.4.0)

#### What's Changed

- Fix regex flags accidentally passed as count by
[@&#8203;musicinmybrain](https://github.com/musicinmybrain) in
[https://github.com/pydantic/pydantic-settings/pull/328](https://github.com/pydantic/pydantic-settings/pull/328)
- Deprecate `read_env_file` and move it to `DotEnvSettingsSource` by
[@&#8203;WarpedPixel](https://github.com/WarpedPixel) in
[https://github.com/pydantic/pydantic-settings/pull/318](https://github.com/pydantic/pydantic-settings/pull/318)
- Fix a bug when loading empty yaml file by
[@&#8203;hramezani](https://github.com/hramezani) in
[https://github.com/pydantic/pydantic-settings/pull/330](https://github.com/pydantic/pydantic-settings/pull/330)
- feat: Enable access to the current state in settings sources by
[@&#8203;VictorColomb](https://github.com/VictorColomb) in
[https://github.com/pydantic/pydantic-settings/pull/326](https://github.com/pydantic/pydantic-settings/pull/326)
- Add support for short options. by
[@&#8203;kschwab](https://github.com/kschwab) in
[https://github.com/pydantic/pydantic-settings/pull/339](https://github.com/pydantic/pydantic-settings/pull/339)
- Add Azure Key Vault settings source by
[@&#8203;AndreuCodina](https://github.com/AndreuCodina) in
[https://github.com/pydantic/pydantic-settings/pull/272](https://github.com/pydantic/pydantic-settings/pull/272)
- Add cli_exit_on_error config option by
[@&#8203;kschwab](https://github.com/kschwab) in
[https://github.com/pydantic/pydantic-settings/pull/340](https://github.com/pydantic/pydantic-settings/pull/340)

#### New Contributors

- [@&#8203;musicinmybrain](https://github.com/musicinmybrain) made
their first contribution in
[https://github.com/pydantic/pydantic-settings/pull/328](https://github.com/pydantic/pydantic-settings/pull/328)
- [@&#8203;WarpedPixel](https://github.com/WarpedPixel) made their
first contribution in
[https://github.com/pydantic/pydantic-settings/pull/318](https://github.com/pydantic/pydantic-settings/pull/318)
- [@&#8203;VictorColomb](https://github.com/VictorColomb) made their
first contribution in
[https://github.com/pydantic/pydantic-settings/pull/326](https://github.com/pydantic/pydantic-settings/pull/326)
- [@&#8203;AndreuCodina](https://github.com/AndreuCodina) made their
first contribution in
[https://github.com/pydantic/pydantic-settings/pull/272](https://github.com/pydantic/pydantic-settings/pull/272)

**Full Changelog**:
pydantic/pydantic-settings@v2.3.4...v2.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjEuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

kschwab deleted the remove_cli_system_exit branch

August 16, 2024 19:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet