-
Notifications
You must be signed in to change notification settings - Fork 312
Better document SerializationInfo
#1747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Viicos,
In another place, Pydantic is less restrictive and allows the use of mode:
Literal['json', 'python'] | str = 'python', so using only aLiteralwith two possibilities won't cause any problems?On our end, MyPy throws errors because we use a custom mode for some models. Perhaps the other mode definitions (in pydantic) will evolve, and we'll have to find another way to use the "custom" mode. However, I currently don't know how to do that.
Best regards,
J.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @l00ptr, could you please provide more details on how you managed to integrate a custom mode in your Pydantic code? We currently support only two hardcoded modes, and I'd like to avoid "advertising" than custom modes may be supported while it isn't the case.
The existing
Literal['json', 'python'] | strannotations were introduced a long time ago in pydantic/pydantic#4978, my best guess being that it wasn't clear if only two modes were to be supported.