Skip to content

Conversation

@davidhewitt
Copy link
Contributor

Change Summary

Since we moved to uv we can guarantee that maturin should be properly installed in the venv, so this should be fine to run like this.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@davidhewitt davidhewitt added the Full Build cause CI to do a full build label Feb 5, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 5, 2025

CodSpeed Performance Report

Merging #1622 will not alter performance

Comparing dh/uv-run-maturin (e8c5b46) with main (ed15f6c)

Summary

✅ 157 untouched benchmarks

@davidhewitt davidhewitt merged commit fdccecd into main Feb 5, 2025
60 checks passed
@davidhewitt davidhewitt deleted the dh/uv-run-maturin branch February 5, 2025 15:52
davidhewitt added a commit to pydantic/pydantic that referenced this pull request Oct 20, 2025
davidhewitt added a commit to pydantic/pydantic that referenced this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Full Build cause CI to do a full build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants