remove uses of IntoPy #1578
Merged
remove uses of IntoPy #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1578 will not alter performanceComparing Summary
|
davidhewitt
force-pushed
the
dh/pyo3-0.23-into-py
branch
from
4cc9490 to
cb0efed
Compare
davidhewitt
commented
Dec 12, 2024
| @@ -575,7 +599,7 @@ impl TzInfo { | |||
| } | |||
| let offset_seconds: f64 = offset_delta.call_method0(intern!(py, "total_seconds"))?.extract()?; | |||
| let offset = offset_seconds.round() as i32; | |||
| Ok(op.matches(self.seconds.cmp(&offset)).into_py(py)) | |||
| op.matches(self.seconds.cmp(&offset)).into_py_any(py) | |||
There was a problem hiding this comment.
Probably a lot more of the .into_py(py) calls could have been replaced with just .into_py_any(py) (after adjusting for error handling) but I couldn't stop myself using more efficient alternatives where I spotted them 🙈
sydney-runkle
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Nice, thanks @davidhewitt! Some nice speedups here: https://codspeed.io/pydantic/pydantic-core/branches/dh%2Fpyo3-0.23-into-py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Followup to #1577
Cleaning up after PyO3 0.23 update.
Related issue number
N/A
Checklist
pydantic-core(except for expected changes)