-
Notifications
You must be signed in to change notification settings - Fork 312
Validate base64 standard encoding #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
please review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1395 +/- ##
==========================================
- Coverage 90.21% 89.61% -0.60%
==========================================
Files 106 109 +3
Lines 16339 17308 +969
Branches 36 41 +5
==========================================
+ Hits 14740 15511 +771
- Misses 1592 1777 +185
- Partials 7 20 +13
... and 39 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
CodSpeed Performance ReportMerging #1395 will not alter performanceComparing Summary
|
davidhewitt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, feature design and implementation looks good to me!
Original-commit-hash: 585f725
Change Summary
Extends bytes base64 validation to accept standard encoding, in addition to the existing URL-safe.
I think a user providing base64 standard input is more likely to want successful (and unambiguous) decoding rather than a validation error. (Even while
ser_json_bytes="base64"continues to emit the URL-safe variant.)Related issue number
No issue, but this extends #1308: #1308 (comment)
Checklist
pydantic-core(except for expected changes)Selected Reviewer: @dmontagu