-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use little endian int #1372
use little endian int #1372
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #1372 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending happy CI, this looks great! Thanks for the quick fix.
Thanks for helping out! |
This reverts commit cb696e2.
Change Summary
Construct the uuid with a little endian representation of the int.
Related issue number
After a bit of forensic, I saw that uuid-rs does not convert the endianness of the u128.
#772
and @davidhewitt pointed out in this PR
uuid-rs/uuid#406
I tried to use the byte attribute from the python object, so endianness would be handled by python itself. This negated the speed-up I tried to introduce in the first place.
This conversion is a no-op on little endian platforms and should fix the s390x build.
Checklist
pydantic-core
(except for expected changes)