Fix model field serializer with computed field

[nix010]

Change Summary

Related issue number

fix #1348

Checklist

• Unit tests for the changes exist
• Documentation reflects the changes where applicable
• Pydantic tests pass with this pydantic-core (except for expected changes)
• My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @samuelcolvin

[nix010]

Updated: Figured it out ! tests added

I know the commit didn't come with the test but how do I do

import pydantic
from typing import Any



class MyModel(pydantic.BaseModel):

    other_field: int = 42

    @pydantic.computed_field
    @property
    def my_field(self) -> str:
        return "foo1"

    @pydantic.field_serializer("*")
    def my_field_serializer(self, value: Any, info: pydantic.FieldSerializationInfo) -> Any:
        print(f"{info.field_name} = {value}")
        return value

but MyModel with the SchemaSerializer and model_fields_schema like other tests in tests/serializers/test_model.py

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

[codspeed-hq]

CodSpeed Performance Report

Merging #1349 will not alter performance

_{Comparing nix010:fix-field-serializer-with-computed-field (cc80ddf) with main (0e6b377)}

Summary

✅ 155 untouched benchmarks

[nix010]

please review

[nix010]

The failed CI I think origin from the ruff version ! open to suggestions on fixing those

[sydney-runkle]

Looking good so far - I've added a few change requests.

Have you used this version of pydantic-core locally to make sure that all pydantic tests pass, specifically the one included in the OP's issue?

[sydney-runkle]

Perhaps we should do something with the info to verify that the correct data is present...

[nix010]

sure, what should we test for ?

[sydney-runkle]

Maybe just that you can extract the name of the field?

[nix010]

ok. I have updated it.

[nix010]

Looking good so far - I've added a few change requests.

Have you used this version of pydantic-core locally to make sure that all pydantic tests pass, specifically the one included in the OP's issue?

yep.

import pydantic
from typing import Any

class MyModel(pydantic.BaseModel):

    other_field: int = 42

    @pydantic.computed_field
    @property
    def my_field(self) -> str:
        return "foo1"

    @pydantic.field_serializer("*")
    def my_field_serializer(self, value: Any, info: pydantic.FieldSerializationInfo) -> Any:
        print(f"{info.field_name} = {value}")
        return value


print(MyModel().model_dump())
print(MyModel().model_dump_json())

"""
other_field = 42
my_field = foo1
{'other_field': 42, 'my_field': 'foo1'}
other_field = 42
my_field = foo1
{"other_field":42,"my_field":"foo1"}
"""

[sydney-runkle]

Great work @NeevCohen!!!