Skip to content

Conversation

@NeevCohen
Copy link
Contributor

@NeevCohen NeevCohen commented Apr 3, 2024

Change Summary

Adding coerce_numbers_to_str option in StringSchema typed dict definition, fixing the failing tests in pydantic side

Related issue number

pydantic/pydantic#9137

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@NeevCohen
Copy link
Contributor Author

please review

@codecov
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 3, 2024

CodSpeed Performance Report

Merging #1262 will not alter performance

Comparing NeevCohen:fix/coerce-numbers-to-str-in-string-schema (87ddbd1) with main (683c5a3)

Summary

✅ 155 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants