Skip to content

Conversation

@samuelcolvin
Copy link
Member

It was wrongly named and had confusion overlap with Into, it's also annoying me WRT jiter.

@codecov
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Merging #1169 (a36d615) into main (4538190) will decrease coverage by 0.02%.
The diff coverage is 83.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1169      +/-   ##
==========================================
- Coverage   90.00%   89.98%   -0.02%     
==========================================
  Files         106      106              
  Lines       16656    16654       -2     
  Branches       36       36              
==========================================
- Hits        14991    14986       -5     
- Misses       1658     1661       +3     
  Partials        7        7              
Files Coverage Δ
src/errors/line_error.rs 93.15% <100.00%> (+0.09%) ⬆️
src/errors/location.rs 97.22% <100.00%> (+0.07%) ⬆️
src/errors/mod.rs 92.30% <ø> (ø)
src/input/input_abstract.rs 70.58% <ø> (ø)
src/input/return_enums.rs 84.97% <100.00%> (ø)
src/lookup_key.rs 92.69% <100.00%> (ø)
src/validators/arguments.rs 99.58% <100.00%> (ø)
src/validators/call.rs 98.11% <100.00%> (ø)
src/validators/dataclass.rs 97.80% <100.00%> (-0.01%) ⬇️
src/validators/dict.rs 95.91% <100.00%> (+0.08%) ⬆️
... and 9 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4538190...a36d615. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 21, 2024

CodSpeed Performance Report

Merging #1169 will degrade performances by 20.96%

Comparing remove-AsLocItem (a36d615) with main (4538190)

Summary

⚡ 3 improvements
❌ 1 regressions
✅ 142 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main remove-AsLocItem Change
test_core_future_str 39.6 µs 32 µs +23.62%
test_core_str 38.9 µs 31.5 µs +23.39%
test_core_future 37.7 µs 29.9 µs +25.9%
test_validate_literal[json-few_mixed] 29.6 µs 37.5 µs -20.96%

Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is a good simplification 👍

@davidhewitt
Copy link
Contributor

(I checked the perf volatility is just the usual PyO3 GILPool pain...)

@davidhewitt davidhewitt merged commit c670b2b into main Jan 22, 2024
@davidhewitt davidhewitt deleted the remove-AsLocItem branch January 22, 2024 11:46
davidhewitt pushed a commit to pydantic/pydantic that referenced this pull request Oct 20, 2025
davidhewitt pushed a commit to pydantic/pydantic that referenced this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants