Use .iter() API to fully replace existing streaming implementation
#951
+155
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Preview
|
dmontagu
force-pushed
the
dmontagu/graph-run-streaming
branch
from
302b8bf to
55ab7f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress on top of #833. I wanted to see this through to make sure that we had a plan for using the node streaming from #833 to replace our current streaming implementation APIs, and with this branch in the state it is, I feel pretty convinced that it's going to work and we'll be able to use the implementation here (perhaps with some tweaks) to achieve full capability parity with the existing APIs, while also being significantly more flexible and powerful.
I think we should merge #833 first without it being capable of fully replacing the
Agent.run_streamAPI, etc., but once that is merged I think we should aim to merge this shortly after and use it to replace the streaming APIs more fully.