Skip to content

Fix tests for Logfire>=3.22.0 #2346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 5, 2025
Merged

Fix tests for Logfire>=3.22.0 #2346

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
db3fb03
Fix tests for Logfire>=3.22.0
medaminezghal Jul 29, 2025
b2a65f7
Merge branch 'main' into fix-logfire-test
medaminezghal Aug 2, 2025
ddd7411
Revert Logfire version restriction
medaminezghal Aug 2, 2025
d083200
Revert reverting Logfire version restriction
medaminezghal Aug 2, 2025
5ba9656
Trying to fix lower versions tests
medaminezghal Aug 2, 2025
5c78b06
Merge branch 'main' into fix-logfire-test
medaminezghal Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pydantic_ai_slim/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ dependencies = [

[tool.hatch.metadata.hooks.uv-dynamic-versioning.optional-dependencies]
# WARNING if you add optional groups, please update docs/install.md
logfire = ["logfire>=3.11.0"]
logfire = ["logfire>=3.22.0"]
# Models
openai = ["openai>=1.92.0"]
cohere = ["cohere>=5.16.0; platform_system != 'Emscripten'"]
Expand Down
1 change: 1 addition & 0 deletions tests/models/test_fallback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ def test_all_failed_instrumented(capfire: CaptureLogfire) -> None:
'logfire.span_type': 'span',
'logfire.msg': 'chat fallback:function:failure_response:,function:failure_response:',
'logfire.level_num': 17,
'gen_ai.response.model': 'fallback:function:failure_response:,function:failure_response:',
Copy link
Contributor

@alexmojaki alexmojaki Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is easy to account for in other ways, this is not enough reason to restrict the version of logfire.

Copy link
Contributor Author

@medaminezghal medaminezghal Aug 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexmojaki The tests won't succeed when using logfire<3.22. If you think that restricting Logfire version isn't good reason for this PR, I will close it.

Copy link
Contributor

@alexmojaki alexmojaki Aug 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests won't pass as they are. You can make them pass.

It's good to test the newest version of logfire, this PR is a good idea, but the minimum version doesn't need to be raised.

},
'events': [
{
Expand Down
8 changes: 4 additions & 4 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.