-
-
Notifications
You must be signed in to change notification settings - Fork 47
ci: add builds for windows 11 arm #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #210 will not alter performanceComparing Summary
|
38119dc
to
24ec109
Compare
c62b2ff
to
561bd7b
Compare
hi @davidhewitt, I have a possibly stupid question... I was poking around and have noticed that in this repo as well as others the pydantic-et-al team does "PGO" builds. What/why is that? When should it be used? When should it not be used? -jesse |
PGO is profile guided optimization. By running the test suite with special instrumentation the compiler can record the hot paths and then optimize the final artifact to make those as efficient as possible. |
On |
Hi @davidhewitt,
|
Hi @davidhewitt! Thanks for the explanation! Does that mean you are getting a build that is optimized for your test suite? Ie your test suite should ideally be representative of real world use cases? How difficult is it to set up pgo builds? |
Yep exactly. The more comprehensive your test suite the better :)
At the moment, quite painful - the best examples are the build scripts here, in pydantic core, and also my discussion in PyO3/maturin#1840 |
32d89e0
to
9a378a2
Compare
Closes #209