Skip to content

Conversation

@samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented May 21, 2024

fix #82

To install:

pip install git+https://github.com/pydantic/jiter.git@partial-json-partial-strings#subdirectory=crates/jiter-python

@codspeed-hq
Copy link

codspeed-hq bot commented May 21, 2024

CodSpeed Performance Report

Merging #101 will improve performances by 12.92%

Comparing partial-json-partial-strings (ef1b244) with main (240f180)

Summary

⚡ 2 improvements
✅ 71 untouched benchmarks

Benchmarks breakdown

Benchmark main partial-json-partial-strings Change
x100_jiter_iter 2.9 µs 2.6 µs +12.92%
x100_jiter_value 3.4 µs 3 µs +10.14%

@codecov
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 94.54545% with 6 lines in your changes are missing coverage. Please review.

Files Patch % Lines
crates/jiter/src/python.rs 81.81% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@samuelcolvin samuelcolvin requested a review from davidhewitt May 21, 2024 20:49
@samuelcolvin samuelcolvin merged commit c7f8fdd into main May 22, 2024
@samuelcolvin samuelcolvin deleted the partial-json-partial-strings branch May 22, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v2.7.0b1 pydantic_core.from_json(..., allow_partial=True) truncates partial strings completely

4 participants