✨ Assign issues to a designated assignee #17
Conversation
| def assign_new(self): | ||
| assignee = self._select_assignee() | ||
| self._assign_user(assignee) | ||
| self._add_label(self.config.unconfirmed_label) |
There was a problem hiding this comment.
what is the example use here of changing labels?
There was a problem hiding this comment.
A new issue gets unconfirmed label. After confirming contributor removes unconfirmed label.
There is a TODO in process_issue doc string suggesting adding a reaction on a magic comment like "can confirm" that should change unconfirmed label to confirmed.
src/logic/issues.py
Outdated
| @dataclass(kw_only=True) | ||
| class LabelAssign: | ||
| # for example "Selected Assignee: @samuelcolvin" | ||
| ASSIGNEE_REGEX: typing.ClassVar[re.Pattern] = re.compile(r'selected[ -]assignee:\s*@([\w\-]+)$', flags=re.I) |
There was a problem hiding this comment.
| ASSIGNEE_REGEX: typing.ClassVar[re.Pattern] = re.compile(r'selected[ -]assignee:\s*@([\w\-]+)$', flags=re.I) | |
| ASSIGNEE_REGEX: typing.ClassVar[re.Pattern] = re.compile(r'selected[ -]assignee:\s*@([\w\-]+)$', flags=re.I) |
I don't think this should necessarily have to end the line or all text.
There was a problem hiding this comment.
Yes, the issue may be edited by the author.
As your suggestion is empty I assume you are suggesting removing trailing $ from the regex. I would rather enable multiline and add leading ^. This will require the text to be on a dedicated line but will allow it to be in any place of the issue body.
BTW, this is just a copy of the reviewer regex from the sibling pr module.
There was a problem hiding this comment.
agree requiring a new line is good, ideally we'd reuse the regex in both places.
Co-authored-by: Samuel Colvin <[email protected]>
Co-authored-by: Samuel Colvin <[email protected]>
lig
force-pushed
the
assign-issues
branch
2 times, most recently
from
b80a7ee
to
5ca7522
Compare
|
please review :) |
src/logic/issues.py
Outdated
| @dataclass(kw_only=True) | ||
| class LabelAssign: | ||
| # for example "Selected Assignee: @samuelcolvin" | ||
| ASSIGNEE_REGEX: typing.ClassVar[re.Pattern] = re.compile(r'selected[ -]assignee:\s*@([\w\-]+)$', flags=re.I) |
There was a problem hiding this comment.
agree requiring a new line is good, ideally we'd reuse the regex in both places.
|
please review |
No description provided.