♻️ Remove mypy type inferencer #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
commented
Jun 15, 2023
| return None | ||
|
|
||
| base_fqn: QualifiedName = next(iter(base_fqn_set)) # type: ignore | ||
| # NOTE: Should I use the name or the QualifiedName? |
Comment on lines
+64
to
+65
| # TODO: We can run this in parallel - batch it into files / cores. | ||
| # We may need to run the resolve_cache() on each core - not sure. |
There was a problem hiding this comment.
This will be likely needed, at least because the code will be cuter.
Kludex
force-pushed
the
burn/remove-mypy
branch
5 times, most recently
from
311e31b to
e8d4ed8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.