📝 Cleanup README.md #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some sections (I think) were accidentally added, so I removed the one I think was not needed anymore. Also, not sure about the BP008 rule. Can't seem to find it in the code, but I left the README untouched in this regard.
|
I'm not sure how this happened, but good sight! Thanks. 🙏 |
|
BP008 is not there yet. We can comment that block for the time being so it doesn't appear on the README. Would you like to open a PR for it? |
Sure. Opened #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some sections (I think) were accidentally added,
so I removed the one I think was not needed anymore.
"Replace
Configclass bymodel_config" is already in BP002and BP003 is about the Field changes.
Also, not sure about the BP008 rule.
Can't seem to find it in the code,
but I left the README untouched in this regard.