#132 make number of jobs to run in parallel an Option #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssproessig
force-pushed
the
limit_number_of_jobs_via_option
branch
from
43cc8fc
to
3034268
Compare
ssproessig
force-pushed
the
limit_number_of_jobs_via_option
branch
from
3034268
to
b4ee063
Compare
Kludex
requested changes
Oct 3, 2023
Comment on lines
+71
to
+76
| if platform.system() == "Windows" and number_of_jobs > _MAX_JOBS_SUPPORTED_DEFAULT: | ||
| console.log( | ||
| f"Given number of jobs {number_of_jobs} exceeds maximum allowed number " | ||
| f"{_MAX_JOBS_SUPPORTED_DEFAULT}. Using {_MAX_JOBS_SUPPORTED_DEFAULT} instead." | ||
| ) | ||
| number_of_jobs = _MAX_JOBS_SUPPORTED_DEFAULT |
There was a problem hiding this comment.
Do we need to check the OS? Can't we just get the min between the two?
There was a problem hiding this comment.
@Kludex My understanding is that the behavior is only required on Windows. Hence on Linux I could use more jobs than I have logical cores...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
limit to 61 on Windows