Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Use only attributes from the Config class #13

Merged
merged 1 commit into from
Jun 19, 2023
Merged

🐛 Use only attributes from the Config class #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions bump_pydantic/codemods/replace_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,17 @@ def visit_Assign(self, node: cst.Assign) -> None:
self.assign_value = node.value

def visit_AssignTarget(self, node: cst.AssignTarget) -> None:
self.config_args.append(
cst.Arg(
keyword=node.target, # type: ignore[arg-type]
value=self.assign_value,
equal=cst.AssignEqual(
whitespace_before=cst.SimpleWhitespace(""),
whitespace_after=cst.SimpleWhitespace(""),
),
if self.inside_config_class:
self.config_args.append(
cst.Arg(
keyword=node.target, # type: ignore[arg-type]
value=self.assign_value,
equal=cst.AssignEqual(
whitespace_before=cst.SimpleWhitespace(""),
whitespace_after=cst.SimpleWhitespace(""),
),
)
)
)

def leave_Module(self, original_node: Module, updated_node: Module) -> Module:
return updated_node
Expand Down
27 changes: 27 additions & 0 deletions tests/test_replace_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,30 @@ class Config:
allow_arbitrary_types = True
"""
self.assertCodemod(code, code)

def test_reset_config_args(self) -> None:
before = """
from pydantic import BaseModel
class Potato(BaseModel):
class Config:
allow_arbitrary_types = True
potato = Potato()
class Potato2(BaseModel):
class Config:
allow_mutation = True
"""
after = """
from pydantic import ConfigDict, BaseModel
class Potato(BaseModel):
model_config = ConfigDict(allow_arbitrary_types=True)
potato = Potato()
class Potato2(BaseModel):
model_config = ConfigDict(allow_mutation=True)
"""
self.assertCodemod(before, after)
Loading