Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mark custom types #116

Merged
merged 13 commits into from
Sep 18, 2023
Merged

Feature/mark custom types #116

merged 13 commits into from
Sep 18, 2023

Conversation

JensHeinrich
Copy link
Contributor

@JensHeinrich JensHeinrich commented Aug 10, 2023 •
edited by Kludex
Loading

@JensHeinrich
Copy link
Contributor Author

JensHeinrich commented Aug 10, 2023 •
edited
Loading

  • Rebase and reorder to make the "Fixes" commit the last commit after fixing the feature

@JensHeinrich JensHeinrich force-pushed the feature/MarkCustomTypes branch from 545dbd1 to c4797e1 Compare August 11, 2023 06:46
@JensHeinrich JensHeinrich marked this pull request as ready for review August 11, 2023 06:47
@slafs
Copy link
Contributor

slafs commented Aug 11, 2023 •
edited
Loading

Nice! Thank you. This will be useful for us too! 🙇 (haven't reviewed this PR though)

Just noticed that the rule code should probably be BP009 (or BP011 maybe). The last current working one is BP008, but BP009 and BP010 are only mentioned in the README, they are not-implemented and commented out in the README. Looks like the last time a new mod was added (BP008), Marcelo incremented the number of commented out mods and used first "free" one. See #90.

@JensHeinrich
Copy link
Contributor Author

Nice! Thank you. This will be useful for us too! 🙇 (haven't reviewed this PR though)

Just noticed that the rule code should probably be BP009 (or BP011 maybe). The last current working one is BP008, but BP009 and BP010 are only mentioned in the README, they are not-implemented and commented out in the README. Looks like the last time a new mod was added (BP008), Marcelo incremented the number of commented out mods and used first "free" one. See #90.

Ok, thought I would just append to the commented one^^

@JensHeinrich JensHeinrich force-pushed the feature/MarkCustomTypes branch from c4797e1 to d5c8282 Compare September 4, 2023 11:54
@JensHeinrich
Copy link
Contributor Author

Nice! Thank you. This will be useful for us too! 🙇 (haven't reviewed this PR though)

Just noticed that the rule code should probably be BP009 (or BP011 maybe). The last current working one is BP008, but BP009 and BP010 are only mentioned in the README, they are not-implemented and commented out in the README. Looks like the last time a new mod was added (BP008), Marcelo incremented the number of commented out mods and used first "free" one. See #90.

Updated the numbering

Kludex
Kludex requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add a test for when there's already a TODO comment.

Kludex
Kludex reviewed Sep 18, 2023
View reviewed changes
@Kludex Kludex merged commit 507e8cc into pydantic:main Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark methods on arbitrary classes
3 participants
@JensHeinrich @slafs @Kludex