New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `PYTHONWARNDEFAULTENCODING` to pipeline #91

Closed

Kludex opened this issue Jul 12, 2023 · 0 comments · Fixed by #93

Labels

good first issue

Member

Kludex commented Jul 12, 2023

Given this comment #85 (comment), we want to add PYTHONWARNDEFAULTENCODING on the pipeline. Check more about it on https://docs.python.org/3/library/io.html#opt-in-encodingwarning.

The text was updated successfully, but these errors were encountered:

Kludex added the good first issue label

kkirsche added a commit to kkirsche/bump-pydantic that referenced this issue


          Set PYTHONWARNDEFAULTENCODING

156dc2d

Fix pydantic#91 

This merge request sets the `PYTHONWARNDEFAULTENCODING` variable in the GitHub workflow per the documentation at https://docs.github.com/en/actions/learn-github-actions/variables.

I've chosen to set `PYTHONWARNDEFAULTENCODING` to the value `true` to ensure it is clear that this is enabling the feature. With that said, https://docs.python.org/3/library/io.html#opt-in-encodingwarning does not indicate that there is a value of the environment variable that would disable this, so I understand if a different value would be preferred.

kkirsche mentioned this issue

👷 Set PYTHONWARNDEFAULTENCODING in GitHub Workflow #93

Merged

Kludex closed this as completed in #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment