Unify nested variant handling #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jul 14, 2025
| } | ||
|
|
||
| fn append_variant<'m, 'd>(&mut self, variant: Variant<'m, 'd>) { | ||
| fn new_object<'a>(&'a mut self, metadata_builder: &'a mut MetadataBuilder) -> ObjectBuilder<'a> { |
Author
There was a problem hiding this comment.
This is the major change - move the low level appending to the ValueBuffer itself
Then all the recursion seems to fall into place
friendlymatthew
approved these changes
Jul 14, 2025
Member
friendlymatthew
left a comment
friendlymatthew
left a comment
There was a problem hiding this comment.
Great! I will take a look
friendlymatthew
merged this pull request
into
pydantic:friendlymatthew/append-complex
10 of 12 checks passed
friendlymatthew
added a commit
that referenced
this pull request
Jul 14, 2025
Unify nested variant handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets the following from @friendlymatthew
VariantBuilderapache/arrow-rs#7914The high level idea is to handle the low level recursion in
ValueBufferin a uniform wayThen the higher level VariantBuilders simply call into that
I ran out of time today, but I think this approach is pretty promising