Replace pillow dependency with filetype#1847
Closed
cilki wants to merge 2 commits intopycontribs:mainfrom
cilki:replace_pillow
Closed
Replace pillow dependency with filetype#1847cilki wants to merge 2 commits intopycontribs:mainfrom cilki:replace_pillow
cilki wants to merge 2 commits intopycontribs:mainfrom
cilki:replace_pillow
Conversation
for more information, see https://pre-commit.ci
|
Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found: |
adehad
reviewed
Jul 9, 2024
Contributor
adehad
left a comment
adehad
left a comment
There was a problem hiding this comment.
I'm concerned by the current maintained state of filetype but it appears that for images at least we should be fine. I am concerned that we don't have a test for this method yet, so if we can add one in that would give me confidence in using this package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1801