Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

begin separation of x509 crate from cryptography crate #8740

Merged
merged 16 commits into from
Apr 16, 2023

Conversation

reaperhulk
Copy link
Member

this will not be a published crate for now and the separation is incomplete. Putting up for commentary, although if we agree this is generally the right path we'll want to land this (+ review feedback) and then start tracking some tasks for improvement. The goal here is a crate that we may choose to publish that is useful to rust users and provides a clean separation of x509 parse (and encode?) logic from our pyo3 code.

this will not be a published crate for now and the separation is
incomplete.
Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz don't rebase for ease of future reviews :-)

Does the coverage + cargo test stuff not need updating? (I think the cargo test stuff will just work if you set up the workspace)

@reaperhulk
Copy link
Member Author

I've fixed coverage mostly -- there's one missed line on a derive statement that I don't understand but the other is probably real.

@reaperhulk
Copy link
Member Author

One issue that I don't understand but otherwise full coverage now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants