[smart_holder] Fix PYBIND11_INTERNALS_SH_DEF mixup.
#5026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pybind#3283 (merged 2021-09-20).
rwgk
added a commit
to google/pybind11clif
that referenced
this pull request
Feb 20, 2024
git merge smart_holder (pybind/pybind11#5026, pybind/pybind11#5033)
rwgk
added a commit
to rwgk/pybind11clif
that referenced
this pull request
Feb 20, 2024
…ind11/detail/abi_platform_id.h
rwgk
added a commit
to google/pybind11clif
that referenced
this pull request
Feb 20, 2024
Fix merge accident: Equivalent of pybind/pybind11#5026 applied to pybind11/detail/abi_platform_id.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PYBIND11_INTERNALS_SH_DEFwas defined the wrong way around ever since it was introduced with #3283 (merged 2021-09-20).This was discovered by chance, in passing. There were no complaints in all this time.
Suggested changelog entry: