Skip to content

fix: workaround NVCC parse failure in cast_op #4893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rwgk merged 3 commits into from
Oct 21, 2023
Merged

fix: workaround NVCC parse failure in cast_op #4893

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26949b3
Workaround NVCC parse failure in `cast_op`
Flamefire Oct 20, 2023
352b04d
style: pre-commit fixes
pre-commit-ci[bot] Oct 20, 2023
6a23a53
Add comments to result_t referencing PR
Flamefire Oct 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions include/pybind11/cast.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,15 @@ using make_caster = type_caster<intrinsic_t<type>>;
// Shortcut for calling a caster's `cast_op_type` cast operator for casting a type_caster to a T
template <typename T>
typename make_caster<T>::template cast_op_type<T> cast_op(make_caster<T> &caster) {
return caster.operator typename make_caster<T>::template cast_op_type<T>();
using result_t = typename make_caster<T>::template cast_op_type<T>;

@rwgk rwgk Oct 20, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a comment at the end of the line, e.g.

// See PR #4893.

Also below.

In case someone later is considering inlining result_t again, they can easily know why it's here.

return caster.operator result_t();
}
template <typename T>
typename make_caster<T>::template cast_op_type<typename std::add_rvalue_reference<T>::type>
cast_op(make_caster<T> &&caster) {
return std::move(caster).operator typename make_caster<T>::
template cast_op_type<typename std::add_rvalue_reference<T>::type>();
using result_t = typename make_caster<T>::template cast_op_type<
typename std::add_rvalue_reference<T>::type>;
return std::move(caster).operator result_t();
}

template <typename type>
Expand Down