Fix p11_error() implementation and test it #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kislyuk
approved these changes
Jun 22, 2025
Collaborator
Author
|
I kicked off the release flow for v0.8.1. |
Member
|
@MatthiasValvekens I have added you as a deployment reviewer (release manager). You should now be able to approve PyPI release GHA runs if you need to push a release when I'm not available. |
Collaborator
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been doing some experiments to try and remove the limitation that prevents multiple PKCS#11 modules from being loaded at once, and I noticed an unfortunate regression in the library loading handler on POSIX systems. #202 introduced an incorrect call to
PyMem_Free()in there.I've fixed it, added a test, and also added some more safeguards against error message decoding issues. We might have push out a bugfix release to address this, though, since it'll in particular cause segfaults when trying to load nonexistent libs.
Sorry about that :/