-
Notifications
You must be signed in to change notification settings - Fork 77
Initial iteration of multi-platform release flow #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| shell: bash | ||
| run: | | ||
| softhsm2-util --init-token --free --label $PKCS11_TOKEN_LABEL --pin $PKCS11_TOKEN_PIN --so-pin $PKCS11_TOKEN_SO_PIN | ||
| - uses: ./.github/actions/install-softhsm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I extracted the SoftHSMv2 install logic to a separate file initially with the intention to use it for testing wheels during the build phase, but it appears that cibuildwheels uses containers to run its builds, so that didn't work out as planned. I left the install-softhsm action in place, though, since it keeps things a bit more readable.
46f13e3 to
76d6093
Compare
kislyuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MatthiasValvekens great job, some minor comments. Since you have contributor permissions now, I'm going to switch to approving instead of merging, please merge on your own.
76d6093 to
93d12ac
Compare
The encoded length of a DSA key is strictly speaking not exactly predictable.
- Upload both sdist and wheels - Reasonable selection of build targets - Integrate with GitHub releases - Manage released version based on git tag - Support multiple release environments - Move extension module setup into pyproject.toml It seems that the explicit linkage against user32.lib on Windows is no longer required. - Divide dependencies into groups Fixes pyauth#203.
93d12ac to
d45957f
Compare
|
Thanks for the review @kislyuk, I addressed your comment & merged this PR. I also took the liberty to go ahead and merge some of the uncontroversial outstanding bugfix PRs (I left the unreviewed feature additions alone for now). There were several PRs to update the headers to PKCS#11 3.1 and expose some of the new 3.1 functionality in the CPython layer. I consolidated those into #205. Once that one's in, maybe we can cut an actual release? 😄 |
As promised in #203.
Result of a test run in TestPyPI: https://test.pypi.org/project/python-pkcs11/0.8.0.dev1/#files. I've spot-tested some of the macOS and Windows wheels by hand, they seem to be working.
Besides the above, I also reorganised the
pyproject.tomlfile a bit, and fixed a flaky test (now that we're running multiple jobs on every commit, the probability that at least one lands in the "freak accident" failure case is relatively high...).