-
Notifications
You must be signed in to change notification settings - Fork 43
Use qtpy, deprecate superqt.qtcompat, drop support for Qt <5.12 #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e33d115
2860d4a
f387c9f
d372711
f1baa12
fd2f048
ae71bd4
b3e6abd
f4616ef
9fb42d2
01d27c6
bbf197a
410e5fe
925667f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| ignore: | ||
| - superqt/_version.py | ||
| - superqt/qtcompat/* | ||
| - '*_tests*' | ||
| coverage: | ||
| status: | ||
|
|
||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add minimal version requirement, Without this update of superqt will not force update of qtpy, so compatibility with PySide6/PyQt6 will be missed.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, I hesitate to do that in case someone wanted to use an older version of qtpy with qt 5.15?
Its not that superqt required 2.0+, it's that PyQt6 does... So it could make some environment resolutions more difficult if we do that.
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there release from the time of introduction qtcompat? If yes hen someone may have code that uses
superqt, and have an older version ofqtpyin the environment, then after the update, the code will be broken. But maybe this is enough small that put information in readme will be enough.