Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove type wrapper, preparing for improved type-map resolution #448

Merged
merged 23 commits into from
Oct 29, 2022

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Aug 25, 2022

first part of #474 ... see also #475

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #448 (5008bdd) into main (93be7a3) will increase coverage by 1.42%.
The diff coverage is 94.94%.

@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
+ Coverage   88.09%   89.52%   +1.42%     
==========================================
  Files          31       31              
  Lines        4193     4000     -193     
==========================================
- Hits         3694     3581     -113     
+ Misses        499      419      -80     
Impacted Files Coverage Δ
magicgui/widgets/_bases/widget.py 87.93% <50.00%> (ø)
magicgui/widgets/_bases/categorical_widget.py 84.00% <66.66%> (-0.94%) ⬇️
magicgui/types.py 96.07% <81.81%> (-3.93%) ⬇️
magicgui/_type_resolution.py 93.22% <93.22%> (ø)
magicgui/signature.py 96.62% <100.00%> (-0.04%) ⬇️
magicgui/type_map.py 96.56% <100.00%> (+0.84%) ⬆️
magicgui/widgets/_bases/create_widget.py 97.43% <100.00%> (+0.06%) ⬆️
magicgui/widgets/_bases/ranged_widget.py 88.97% <100.00%> (+0.08%) ⬆️
magicgui/widgets/_bases/value_widget.py 98.38% <100.00%> (+1.56%) ⬆️
magicgui/widgets/_concrete.py 86.81% <100.00%> (-0.03%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tlambert03 tlambert03 changed the base branch from main to dev October 22, 2022 20:07
@tlambert03 tlambert03 merged commit 23372b0 into pyapp-kit:main Oct 29, 2022
@tlambert03 tlambert03 deleted the new-typemap branch October 29, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant