Skip to content

Fix update-contributors handling of missing github_username #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
blink1073 wants to merge 4 commits into from
Closed

Fix update-contributors handling of missing github_username #176

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d81ad6b
Debug update-contributors
blink1073 Jul 3, 2024
b95d0aa
add package name
blink1073 Jul 3, 2024
c41b7bb
try all exceptions
blink1073 Jul 3, 2024
d0f2346
warn instead of failing
blink1073 Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/pyosmeta/cli/update_review_teams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"""

import os
import warnings
from datetime import datetime

from pydantic import ValidationError
Expand Down Expand Up @@ -87,9 +88,18 @@ def main():

else:
# Else we are processing editors, reviewers...
gh_user = get_clean_user(
getattr(packages[pkg_name], issue_role)["github_username"]

# Get the Github username if possible.
raw_user = getattr(packages[pkg_name], issue_role).get(
"github_username"
)
if raw_user is None:
warnings.warn(
f"No github_username found for {pkg_name}!",
stacklevel=2,
)
continue
gh_user = get_clean_user(raw_user)

if gh_user not in contribs.keys():
# If they aren't already in contribs, add them
Expand Down